Using addanalysis on a run unhides it.

(This explains a lot. How can a run be visible if no one uses "unhide" in the ng6 http logs?)

This can definitely be tested easily, but I'll ask Jules if I need an exemple.

changed milestone to %V3.3

added Bug label

assigned to @rtherville

Tested on the following run : https://ng6.toulouse.inra.fr/projects?tx_nG6_pi1%5Bproject_id%5D=7&tx_nG6_pi1%5Brun_id%5D=1292&cHash=c99611192492629d61b59b64fa496dfe

The run is still hidden. TODO: look for a better exemple with Jules.

Look at this nG6 run : https://ng6.toulouse.inra.fr/projects?tx_nG6_pi1%5Bproject_id%5D=1648&tx_nG6_pi1%5Brun_id%5D=19411&cHash=cf84b4137d8736fd716600e4f2416eb2

I had add two supplementary analysis on this run. The run was hiden before the first add. A the end of it, the run was unhiden. I hid it and I add another analysis. The run was stil hiden...

More NG6 runs concerned :

https://ng6.toulouse.inra.fr/projects?tx_nG6_pi1%5Bproject_id%5D=1849&tx_nG6_pi1%5Brun_id%5D=19186&cHash=3c83c63f29c2217913823fed03f71b46

https://ng6.toulouse.inra.fr/projects?tx_nG6_pi1%5Bproject_id%5D=1849&tx_nG6_pi1%5Brun_id%5D=19187&cHash=968ea1651c973669a0bd671c9b41ae1f

PS : No, I can't test on those...

bugged run ids: project 1648 run 19411, project 1849 run 19186, project 1849 run 19187

I couldn't find the bug's origin in the request or htaccess file. Let's dive in the sources.

I can't confirm about addanalysis yet, bug hiding/unhiding an analysis often impacts the parent run.

https://ng6.toulouse.inra.fr/projects?tx_nG6_pi1%5Bproject_id%5D=7&tx_nG6_pi1%5Brun_id%5D=19048&cHash=78d7a5e5ccb184390abc1e0b2ebc0faa

See the following : https://forgemia.inra.fr/genotoul-bioinfo/ng6/-/blob/master/ui/nG6/Classes/Controller/tx_nG6_db.php#L2489

Unhidding a run unhides its analyses.

Unhiding an analyse unhides its run AND project.

The "cascade" option is always on. We could change that...

TODO:

Modify the calls here https://forgemia.inra.fr/genotoul-bioinfo/ng6/-/blob/master/ui/nG6/Classes/Controller/ng6.php#L129 to avoid unhide_run() and unhide_analysis() from impacting the run/project above.

mentioned in commit 4111f259

mentioned in merge request !138 (merged)

The fix above didn't work.

What we have:

• unhide impacts the elements above and below
• hide impacts the elements above and below

What we want:

• unhide impacts the elements below
• hide impacts the elements below

When we use tx_nG6_db::unhide_run() and tx_nG6_db::unhide_analysis() with $unhide_up=false, one problem remains...

-> Unhiding an analysis ALWAYS impacts the run above, for no apparant reason.

mentioned in merge request !139 (merged)

mentioned in commit c4881413

mentioned in merge request !140 (merged)

closed